dongjoon-hyun commented on code in PR #298:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/298#discussion_r2306040133
##########
spark-operator/src/main/java/org/apache/spark/k8s/operator/config/SparkOperatorConf.java:
##########
@@ -334,6 +334,30 @@ public final class SparkOperatorConf {
.defaultValue(19090)
.build();
+ public static final ConfigOption<Boolean>
ENABLE_PROMETHEUS_TEXT_BASED_FORMAT =
+ ConfigOption.<Boolean>builder()
+
.key("spark.kubernetes.operator.metrics.enablePrometheusTextBasedFormat")
+ .enableDynamicOverride(false)
+ .description(
+ "Whether or not to enable text-based format for Prometheus 2.0,
as "
+ + "recommended by "
+ +
"https://prometheus.io/docs/instrumenting/exposition_formats/#text-based-format";)
+ .typeParameterClass(Boolean.class)
+ .defaultValue(true)
+ .build();
+
+ public static final ConfigOption<Boolean>
ENABLE_SANITIZED_PROMETHEUS_METRICS_NAME =
+ ConfigOption.<Boolean>builder()
+
.key("spark.kubernetes.operator.metrics.enableSanitizePrometheusMetricsName")
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
