cloud-fan commented on code in PR #52153:
URL: https://github.com/apache/spark/pull/52153#discussion_r2309660051


##########
sql/core/src/main/scala/org/apache/spark/sql/classic/Dataset.scala:
##########
@@ -1544,6 +1544,35 @@ class Dataset[T] private[sql](
     }
   }
 
+  /**
+   * Repartitions the Dataset using the specified partition ID expression.
+   *
+   * The number of partitions will be configured by 
`spark.sql.shuffle.partitions`.
+   *
+   * @param partitionIdExpr the expression to be used as the partition ID. 
Must be an integral type.
+   *
+   * @group typedrel
+   * @since 4.1.0
+   */
+  def repartitionById(partitionIdExpr: Column): Dataset[T] = {

Review Comment:
   I feel it's risky to provide a default numPartitions. Can we always ask 
users to specify numPartitions?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to