dtenedor commented on code in PR #51298: URL: https://github.com/apache/spark/pull/51298#discussion_r2311303232
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/thetasketchesExpressions.scala: ########## @@ -0,0 +1,321 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.expressions + +import org.apache.datasketches.common.SketchesArgumentException +import org.apache.datasketches.memory.Memory +import org.apache.datasketches.theta.{CompactSketch, SetOperation} + +import org.apache.spark.sql.catalyst.expressions.{ExpectsInputTypes, Expression, ExpressionDescription, Literal} +import org.apache.spark.sql.catalyst.expressions.codegen.CodegenFallback +import org.apache.spark.sql.catalyst.util.ThetaSketchUtils +import org.apache.spark.sql.errors.QueryExecutionErrors +import org.apache.spark.sql.types.{AbstractDataType, BinaryType, DataType, IntegerType, LongType} + +@ExpressionDescription( + usage = """ + _FUNC_(expr) - Returns the estimated number of unique values given the binary representation + of a Datasketches ThetaSketch. """, + examples = """ + Examples: + > SELECT _FUNC_(theta_sketch_agg(col)) FROM VALUES (1), (1), (2), (2), (3) tab(col); + 3 + """, + group = "misc_funcs", + since = "4.1.0") +case class ThetaSketchEstimate(child: Expression) + extends UnaryExpression + with CodegenFallback + with ExpectsInputTypes { + override def nullIntolerant: Boolean = true + + override protected def withNewChildInternal(newChild: Expression): ThetaSketchEstimate = + copy(child = newChild) + + override def prettyName: String = "theta_sketch_estimate" + + override def inputTypes: Seq[AbstractDataType] = Seq(BinaryType) + + override def dataType: DataType = LongType + + override def nullSafeEval(input: Any): Any = { + val buffer = input.asInstanceOf[Array[Byte]] + + val memory = try { + Memory.wrap(buffer) + } catch { + case _: IllegalArgumentException | _: IndexOutOfBoundsException => + throw QueryExecutionErrors.thetaInvalidInputSketchBuffer(prettyName) + } + + val sketch = try { + CompactSketch.wrap(memory) + } catch { + case _: SketchesArgumentException => + throw QueryExecutionErrors.thetaInvalidInputSketchBuffer(prettyName) + } + + Math.round(sketch.getEstimate) + } +} + +// scalastyle:off line.size.limit +@ExpressionDescription( + usage = """ + _FUNC_(first, second, lgNomEntries) - Merges two binary representations of + Datasketches ThetaSketch objects, using a Datasketches Union object. Set + lgNomEntries to a value between 4 and 26 to find the unions of sketches with different + union buffer sizes values (defaults to 12). """, + examples = """ + Examples: + > SELECT theta_sketch_estimate(_FUNC_(theta_sketch_agg(col1), theta_sketch_agg(col2))) FROM VALUES (1, 4), (1, 4), (2, 5), (2, 5), (3, 6) tab(col1, col2); + 6 + """, + group = "misc_funcs", + since = "4.1.0") +// scalastyle:on line.size.limit +case class ThetaUnion(first: Expression, second: Expression, third: Expression) + extends TernaryExpression + with CodegenFallback + with ExpectsInputTypes { + override def nullIntolerant: Boolean = true + + def this(first: Expression, second: Expression) = { + this(first, second, Literal(ThetaSketchUtils.DEFAULT_LG_NOM_LONGS)) + } + + def this(first: Expression, second: Expression, third: Int) = { + this(first, second, Literal(third)) + } + + override protected def withNewChildrenInternal( + newFirst: Expression, + newSecond: Expression, + newThird: Expression): ThetaUnion = + copy(first = newFirst, second = newSecond, third = newThird) + + override def prettyName: String = "theta_union" + + override def inputTypes: Seq[AbstractDataType] = Seq(BinaryType, BinaryType, IntegerType) + + override def dataType: DataType = BinaryType + + override def nullSafeEval(value1: Any, value2: Any, value3: Any): Any = { + val logNominalEntries = value3.asInstanceOf[Int] + ThetaSketchUtils.checkLgNomLongs(logNominalEntries) + + val memory1 = try { + Memory.wrap(value1.asInstanceOf[Array[Byte]]) + } catch { + case _: IllegalArgumentException | _: IndexOutOfBoundsException => + throw QueryExecutionErrors.thetaInvalidInputSketchBuffer(prettyName) + } + + val sketch1 = try { + CompactSketch.wrap(memory1) + } catch { + case _: SketchesArgumentException => + throw QueryExecutionErrors.thetaInvalidInputSketchBuffer(prettyName) + } + + val memory2 = try { Review Comment: Sounds good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
