dtenedor commented on code in PR #51298:
URL: https://github.com/apache/spark/pull/51298#discussion_r2311325422
##########
sql/core/src/test/resources/sql-tests/inputs/thetasketch.sql:
##########
@@ -0,0 +1,493 @@
+-- Positive test cases
+-- Create tables with two columns for each data type
+
+-- Integer table
+DROP TABLE IF EXISTS t_int;
+CREATE TABLE t_int AS
Review Comment:
Doing another review pass over these golden file tests, the test coverage
seems high. Thanks for that. The review effort is somewhat difficult to keep
switching back to the definitions of the tables, and then the query results to
verify they are correct. I wonder if we can modify the table names themselves
to suggest the values inside. Something like `t_int_1_12_through_14_12`. While
we do this, if we could slightly massage the values lists to be easy to read
consecutively too, that could be great. Something like
```
CREATE TABLE t_int_1_11_through_7_17 AS
VALUES
(1, 11), (2, 12), (3, 13), (4, 14), (5, 15), (6, 16), (7, 17) AS tab(col1,
col2);
```
Super pro-tip: you don't need the `SELECT *` part since a `VALUES` list is a
valid stand-alone query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
