davidm-db commented on code in PR #52173:
URL: https://github.com/apache/spark/pull/52173#discussion_r2313547217
##########
sql/connect/common/src/main/scala/org/apache/spark/sql/connect/SparkSession.scala:
##########
@@ -250,6 +250,13 @@ class SparkSession private[sql] (
sql(query, Array.empty)
}
+ /** @inheritdoc */
+ def sql(sqlText: String, args: Array[_], paramNames: Array[String]):
DataFrame = {
+ // For Connect, delegate to existing positional parameter implementation
+ // The unified parameter logic is handled on the server side
+ sql(sqlText, args)
Review Comment:
Ok, I just now realized we are throwing
`INVALID_QUERY_MIXED_QUERY_PARAMETERS` in such cases - what is the goal of the
new API then? Why don't the previous two suffice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
