davidm-db commented on code in PR #52173:
URL: https://github.com/apache/spark/pull/52173#discussion_r2313604960


##########
sql/core/src/test/resources/sql-tests/inputs/execute-immediate.sql:
##########
@@ -140,10 +142,40 @@ EXECUTE IMMEDIATE 'SELECT id FROM tbl_view WHERE id = :p' 
USING p, 'p';
 EXECUTE IMMEDIATE 'SELECT id, data.f1 FROM tbl_view WHERE id = 10' INTO 
res_id, res_id;
 
 -- nested execute immediate
-EXECUTE IMMEDIATE 'EXECUTE IMMEDIATE \'SELECT id FROM tbl_view WHERE id = ? 
USING 10\'';

Review Comment:
   looks like it was a bad test, i.e. in the old version the text of the query 
in the inner EXECUTE IMMEDIATE is `SELECT id FROM tbl_view WHERE id = ? USING 
10` which is not correct SQL. It was not exposed since nested EXECUTE IMMEDIATE 
was not allowed and that's the first thing that was hit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to