TeodorDjelic commented on code in PR #52298:
URL: https://github.com/apache/spark/pull/52298#discussion_r2341059901
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingParserSuite.scala:
##########
@@ -2842,12 +2842,12 @@ class SqlScriptingParserSuite extends SparkFunSuite
with SQLHelper {
assert(exception.origin.line.contains(6))
}
- test("continue handler not supported") {
+ test("declare exit handler for qualified condition name that is not
supported") {
Review Comment:
Maybe its a good idea to have redundant checks, to do black box testing,
instead of white box testing.
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingParserSuite.scala:
##########
@@ -2842,12 +2842,12 @@ class SqlScriptingParserSuite extends SparkFunSuite
with SQLHelper {
assert(exception.origin.line.contains(6))
}
- test("continue handler not supported") {
+ test("declare exit handler for qualified condition name that is not
supported") {
Review Comment:
Maybe its a good idea to have redundant checks, to do black box testing,
instead of white box testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
