dusantism-db commented on code in PR #52298:
URL: https://github.com/apache/spark/pull/52298#discussion_r2343469651
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingParserSuite.scala:
##########
@@ -2842,12 +2842,12 @@ class SqlScriptingParserSuite extends SparkFunSuite
with SQLHelper {
assert(exception.origin.line.contains(6))
}
- test("continue handler not supported") {
+ test("declare exit handler for qualified condition name that is not
supported") {
Review Comment:
I think he just copied the test and changed to continue handler, which is
fine IMO - doesn't hurt to have more tests. The diff is just weird for some
reason. However, I think we shouldn't remove the old tests yet ("continue
handler not supported") until we remove the feature flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
