heyihong commented on code in PR #52342:
URL: https://github.com/apache/spark/pull/52342#discussion_r2355236347
##########
sql/connect/common/src/test/resources/query-tests/queries/column_between.json:
##########
@@ -40,7 +40,11 @@
}
}, {
"literal": {
- "integer": 10
Review Comment:
The implementation logic was simplified (262 lines of code added and 464
lines removed) in
`sql/connect/common/src/main/scala/org/apache/spark/sql/connect/common/LiteralValueProtoConverter.scala`.
In addition, the protobuf message schema was simplified (1 field added and 3
fields removed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
