heyihong commented on code in PR #52342:
URL: https://github.com/apache/spark/pull/52342#discussion_r2355249780
##########
sql/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -230,18 +234,7 @@ message Expression {
DataType element_type = 1 [deprecated = true];
// The literal values that make up the array elements.
- //
- // For inferring the data_type.element_type, only the first element
needs to
- // contain the type information.
repeated Literal elements = 2;
-
- // The type of the array. You don't need to set this field if the type
information is not needed.
- //
- // If the element type can be inferred from the first element of the
elements field,
- // then you don't need to set data_type.element_type to save space.
- //
- // On the other hand, redundant type information is also acceptable.
- DataType.Array data_type = 3;
Review Comment:
Yes, the old client versions don't use these removed fields. Also , PySpark
Connect still uses the old client version, and it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
