miland-db commented on code in PR #52298:
URL: https://github.com/apache/spark/pull/52298#discussion_r2337238336
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingParserSuite.scala:
##########
@@ -2918,7 +2935,24 @@ class SqlScriptingParserSuite extends SparkFunSuite with
SQLHelper {
assert(exception.origin.line.contains(2))
}
- test("duplicate condition in handler declaration") {
+ test("declare continue handler in wrong place") {
Review Comment:
Not sure if there is a need to test `EXIT/CONTINUE` handlers where it is not
crucial what type it is. I would not duplicate tests like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
