miland-db commented on code in PR #52371: URL: https://github.com/apache/spark/pull/52371#discussion_r2388415159
########## sql/core/src/test/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionNodeSuite.scala: ########## @@ -32,6 +33,16 @@ import org.apache.spark.sql.types.{IntegerType, StructField, StructType} * It is then checked if the leaf statements have been iterated in the expected order. */ class SqlScriptingExecutionNodeSuite extends SparkFunSuite with SharedSparkSession { + protected override def beforeAll(): Unit = { + super.beforeAll() + conf.setConf(SQLConf.SQL_SCRIPTING_CONTINUE_HANDLER_ENABLED, true) + } + + protected override def afterAll(): Unit = { + conf.unsetConf(SQLConf.SQL_SCRIPTING_CONTINUE_HANDLER_ENABLED.key) + super.afterAll() + } + Review Comment: No need to do this if we didn't add any tests using `CONTINUE HANDLER` in this suite. Please look at the [comment](https://github.com/apache/spark/pull/52371/files#r2388408330) above regarding this suite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org