miland-db commented on PR #52371: URL: https://github.com/apache/spark/pull/52371#issuecomment-3347753133
LGTM overall. Please address the pending comments. I’ve noticed that `SqlScriptingExecutionSuite` is growing rapidly and now contains a large number of diverse tests. It might be worth splitting it into smaller, more focused suites. We could have separate suites for specific execution types (e.g., if/else tests, loop tests, exception handler tests, etc.) This would help keep each suite more maintainable and easier to navigate as the test base continues to grow. Hey @davidm-db, @dejankrak-db could you take a look as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
