cboumalh commented on code in PR #52551:
URL: https://github.com/apache/spark/pull/52551#discussion_r2430864723
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/thetasketchesAggregates.scala:
##########
@@ -289,6 +310,10 @@ case class ThetaSketchAgg(
this.createAggregationBuffer()
}
}
+
+ override protected def withNewChildrenInternal(newFirst: Expression,
newSecond: Expression,
+ newThird: Expression): Expression = copy(newFirst, newSecond,
+ newThird, mutableAggBufferOffset, inputAggBufferOffset)
Review Comment:
super nit, the withNewChildrenInternal override doesn’t need to explicitly
pass mutableAggBufferOffset or inputAggBufferOffset. This is redundant. Return
type should also be `ThetaSketchAgg`
can have something like this:
```
override protected def withNewChildrenInternal(
newFirst: Expression, newSecond: Expression, newThird: Expression):
ThetaSketchAgg =
copy(
first = newFirst,
second = newSecond,
third = newThird)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
