cboumalh commented on code in PR #52551:
URL: https://github.com/apache/spark/pull/52551#discussion_r2430828990
##########
python/pyspark/sql/connect/functions/builtin.py:
##########
@@ -4337,12 +4337,17 @@ def hll_union(
def theta_sketch_agg(
col: "ColumnOrName",
lgNomEntries: Optional[Union[int, Column]] = None,
+ family: Optional[str] = None,
Review Comment:
For the sake of consistency, we can consider changing this function to look
like this:
```
def theta_sketch_agg(
col: "ColumnOrName",
lgNomEntries: Optional[Union[int, Column]] = None,
family: Optional["ColumnOrName"] = None,
) -> Column:
fn = "theta_sketch_agg"
_lgNomEntries = lit(12) if lgNomEntries is None else lit(lgNomEntries)
_family = lit("QUICKSELECT") if family is None else _to_col(family)
return _invoke_function_over_columns(fn, col, _lgNomEntries, _family)
```
Similarly in the other builtin.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
