dongjoon-hyun commented on code in PR #52578:
URL: https://github.com/apache/spark/pull/52578#discussion_r2434378692
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PushVariantIntoScan.scala:
##########
@@ -280,8 +281,13 @@ object PushVariantIntoScan extends Rule[LogicalPlan] {
relation @ LogicalRelationWithTable(
hadoopFsRelation@HadoopFsRelation(_, _, _, _, _: ParquetFileFormat, _),
_)) =>
rewritePlan(p, projectList, filters, relation, hadoopFsRelation)
- case p@PhysicalOperation(projectList, filters, relation:
DataSourceV2Relation) =>
- rewriteV2RelationPlan(p, projectList, filters, relation)
+
+ // BEGIN-V2-SUPPORT: DataSource V2 pattern matching with API
+ case p@PhysicalOperation(projectList, filters,
+ scanRelation @ DataSourceV2ScanRelation(
+ relation, scan: SupportsPushDownVariants, output, _, _)) =>
+ rewritePlanV2(p, projectList, filters, scanRelation, scan)
+ // END-V2-SUPPORT
Review Comment:
Ditto. This closing comment also looks a little too strict to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
