gengliangwang commented on code in PR #52595:
URL: https://github.com/apache/spark/pull/52595#discussion_r2441120790
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryRowLevelOperationTable.scala:
##########
@@ -116,10 +114,27 @@ class InMemoryRowLevelOperationTable(
abstract class RowLevelOperationBatchWrite extends TestBatchWrite {
- override def commit(messages: Array[WriterCommitMessage],
- metrics: util.Map[String,
lang.Long]): Unit = {
- metrics.asScala.map {
- case (key, value) => commitProperties += key -> String.valueOf(value)
+ override def commit(messages: Array[WriterCommitMessage], metrics:
WriterMetrics): Unit = {
+ metrics match {
+ case mergeMetrics: MergeMetrics =>
+ commitProperties += "merge.numTargetRowsCopied" ->
Review Comment:
for metrics keys like
`merge.numTargetRowsCopied`/`merge.numTargetRowsDeleted`, shall we standarlize
them in `MergeMetricsImpl`? Otherwise connectors may have different metrics name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
