szehon-ho commented on code in PR #52595:
URL: https://github.com/apache/spark/pull/52595#discussion_r2433050205
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryRowLevelOperationTable.scala:
##########
@@ -116,10 +114,27 @@ class InMemoryRowLevelOperationTable(
abstract class RowLevelOperationBatchWrite extends TestBatchWrite {
- override def commit(messages: Array[WriterCommitMessage],
- metrics: util.Map[String,
lang.Long]): Unit = {
- metrics.asScala.map {
- case (key, value) => commitProperties += key -> String.valueOf(value)
+ override def commit(messages: Array[WriterCommitMessage], metrics:
OperationMetrics): Unit = {
+ metrics match {
Review Comment:
Oh these are then returned and checked via existing test cases.
https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/connector/MergeIntoTableSuiteBase.scala#L1816
do you think something else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
