dongjoon-hyun commented on code in PR #52068:
URL: https://github.com/apache/spark/pull/52068#discussion_r2441199101
##########
core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:
##########
@@ -1058,6 +1060,24 @@ private[spark] class SparkSubmit extends Logging {
/** Throw a SparkException with the given error message. */
private def error(msg: String): Unit = throw new SparkException(msg)
+ /**
+ * Store the diagnostics using the SparkDiagnosticsSetter.
+ */
+ private def storeDiagnostics(
+ args: SparkSubmitArguments,
+ sparkConf: SparkConf,
+ throwable: Throwable): Unit = {
+ // Swallow exceptions when storing diagnostics, this shouldn't fail the
application.
+ try {
+ if (!isShell(args.primaryResource) && !isSqlShell(args.mainClass)
+ && !isThriftServer(args.mainClass)) {
Review Comment:
Is this exhaustive? For example, `isConnectServer`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
