dongjoon-hyun commented on code in PR #52068:
URL: https://github.com/apache/spark/pull/52068#discussion_r2441210152
##########
core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:
##########
@@ -1233,6 +1253,25 @@ private[spark] object SparkSubmitUtils {
case _ => throw new SparkException(s"Spark config without '=': $pair")
}
}
+
+ private[deploy] def getSparkDiagnosticsSetters(
+ master: String,
+ sparkConf: SparkConf): Option[SparkDiagnosticsSetter] = {
+ val loader = Utils.getContextOrSparkClassLoader
+ val serviceLoaders =
+ ServiceLoader.load(classOf[SparkDiagnosticsSetter], loader)
+ .asScala
+ .filter(_.supports(master, sparkConf))
+
+ serviceLoaders.size match {
+ case x if x > 1 =>
+ throw new SparkException(s"Multiple($x) external
SparkDiagnosticsSetter" +
+ s"registered for master url $master.")
Review Comment:
Since we have one `master` URL technically in production, I believe we can
remove line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
