micheal-o commented on code in PR #52527:
URL: https://github.com/apache/spark/pull/52527#discussion_r2411966110
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBMemoryManager.scala:
##########
@@ -121,6 +121,29 @@ object RocksDBMemoryManager extends Logging with
UnmanagedMemoryConsumer {
}
}
+ /**
+ * Get the pinned blocks memory usage for a specific instance, accounting
for bounded memory
+ * sharing.
+ * @param uniqueId The instance's unique identifier
+ * @param globalPinnedUsage The total pinned usage from the cache
+ * @return The adjusted pinned blocks memory usage accounting for sharing in
bounded memory mode
+ */
+ def getInstancePinnedBlocksMemUsage(
+ uniqueId: String,
+ pinnedUsage: Long): Long = {
Review Comment:
nit: param name `pinnedUsage` is different from what is in the description
`globalPinnedUsage`. Lets just name this param as: `totalPinnedUsage`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
