micheal-o commented on code in PR #52527:
URL: https://github.com/apache/spark/pull/52527#discussion_r2408812940
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala:
##########
@@ -3671,6 +3671,53 @@ class RocksDBSuite extends AlsoTestWithRocksDBFeatures
with SharedSparkSession
}
def listFiles(file: String): Seq[File] = listFiles(new File(file))
+
+ test("SPARK-53792: RocksDBMemoryManager getInstancePinnedBlocksMemUsage") {
Review Comment:
nit: move this closer to the other memory manager test case
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -1496,6 +1495,11 @@ class RocksDB(
// Use RocksDBMemoryManager to calculate the memory usage accounting
val memoryUsage =
RocksDBMemoryManager.getInstanceMemoryUsage(instanceUniqueId, getMemoryUsage)
+ val requestedPinnedBlocksMemUsage =
getDBProperty("rocksdb.block-cache-pinned-usage")
Review Comment:
do we actually need the `getDBProperty("rocksdb.block-cache-pinned-usage")`
here? Because in unbounded mode, the
`getDBProperty("rocksdb.block-cache-pinned-usage")` will be equal to
`lruCache.getPinnedUsage()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
