uros-db commented on code in PR #52491:
URL: https://github.com/apache/spark/pull/52491#discussion_r2429427684


##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/parser/DataTypeAstBuilder.scala:
##########
@@ -118,6 +118,30 @@ class DataTypeAstBuilder extends 
SqlBaseParserBaseVisitor[AnyRef] {
             currentCtx.precision.getText.toInt
           }
           TimeType(precision)
+        case GEOGRAPHY =>
+          // Unparameterized geometry type isn't supported and will be caught 
by the default branch.
+          // Here, we only handle the parameterized GEOGRAPHY type syntax, 
which comes in two forms:
+          if (currentCtx.srid.getText.toLowerCase(Locale.ROOT) == "any") {

Review Comment:
   The syntax is not: GEOMETRY(ANY), it's GEOMETRY("ANY"). This is intentional, 
as per the current geospatial types API. We can sync offline and discuss this 
more if you'd like.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to