cloud-fan commented on code in PR #52334:
URL: https://github.com/apache/spark/pull/52334#discussion_r2425237199
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -1666,9 +1680,19 @@ alterColumnAction
| dropDefault=DROP DEFAULT
;
+stringLitWithoutMarker
+ : STRING_LITERAL
#stringLiteralValue
+ | {!double_quoted_identifiers}? DOUBLEQUOTED_STRING
#doubleQuotedStringLiteralValue
+;
+
+parameterMarker
+ : {parameter_substitution_enabled}? namedParameterMarker
#namedParameterMarkerRule
+ | {parameter_substitution_enabled}? QUESTION
#positionalParameterMarkerRule
+ ;
+
stringLit
- : STRING_LITERAL
- | {!double_quoted_identifiers}? DOUBLEQUOTED_STRING
+ : stringLitWithoutMarker
#stringLiteralInContext
+ | parameterMarker
#parameterStringValue
Review Comment:
Correct me if I'm wrong: the pre-parser only allow parameter markers in
`integerValue` and `stringLit`, and we still need the previous framework to
bind parameters at analysis time for arbitrary expressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
