cloud-fan commented on code in PR #52334: URL: https://github.com/apache/spark/pull/52334#discussion_r2435990813
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParameterContext.scala: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.parser + +import org.apache.spark.sql.catalyst.expressions.Expression + +/** + * Context for passing parameter values to the SQL parser. + * This allows parameter substitution to happen during the parsing phase + * rather than during analysis. + */ +sealed trait ParameterContext + +/** + * Context for named parameters (e.g., :paramName). + * + * @param params Map of parameter names to their expression values + */ +case class NamedParameterContext(params: Map[String, Expression]) extends ParameterContext + +/** + * Context for positional parameters (e.g., ?). + * + * @param params Sequence of expression values in order + */ +case class PositionalParameterContext(params: Seq[Expression]) extends ParameterContext + +/** + * Context that supports both named and positional parameters. + * This is used by EXECUTE IMMEDIATE where the parameter type is determined by the inner query. + * + * @param args Raw argument values from USING clause (already evaluated) + * @param paramNames Parameter names from USING clause (empty strings for positional) + */ +case class HybridParameterContext( + args: Array[_], Review Comment: shall we use `Seq[Expression]` to be consistent with the positional context? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
