srielau commented on code in PR #52334: URL: https://github.com/apache/spark/pull/52334#discussion_r2426678273
########## sql/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala: ########## @@ -106,6 +106,7 @@ class SparkConnectPlanner( import sessionHolder.session.toRichColumn private[connect] def parser = session.sessionState.sqlParser + private val parameterHandler = new ParameterHandler() Review Comment: The handler is stateless. What would we gain from creating new instances? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
