cloud-fan commented on code in PR #52334:
URL: https://github.com/apache/spark/pull/52334#discussion_r2416657879
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -1593,6 +1602,12 @@ number
| MINUS? BIGDECIMAL_LITERAL #bigDecimalLiteral
;
+integerValue
+ : INTEGER_VALUE
#integerVal
+ | {parameter_substitution_enabled}? namedParameterMarker
#namedParameterIntegerValue
+ | {parameter_substitution_enabled}? QUESTION
#positionalParameterIntegerValue
Review Comment:
can we add a shared parser rule for parameter markers? then we don't need
two similar visit methods for parameter markers?
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -1593,6 +1602,12 @@ number
| MINUS? BIGDECIMAL_LITERAL #bigDecimalLiteral
;
+integerValue
+ : INTEGER_VALUE
#integerVal
+ | {parameter_substitution_enabled}? namedParameterMarker
#namedParameterIntegerValue
+ | {parameter_substitution_enabled}? QUESTION
#positionalParameterIntegerValue
Review Comment:
can we add a shared parser rule for parameter markers? then we don't need
two similar visit methods for parameter markers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
