jaceklaskowski commented on code in PR #52538:
URL: https://github.com/apache/spark/pull/52538#discussion_r2445893039
##########
sql/pipelines/src/main/scala/org/apache/spark/sql/pipelines/graph/CoreDataflowNodeProcessor.scala:
##########
@@ -198,22 +197,20 @@ private class FlowResolver(rawGraph: DataflowGraph) {
)
}
}
- result
}
private def convertResolvedToTypedFlow(
flow: UnresolvedFlow,
funcResult: FlowFunctionResult): ResolvedFlow = {
- val typedFlow = flow match {
- case f: UnresolvedFlow if f.once => new AppendOnceFlow(flow, funcResult)
- case f: UnresolvedFlow if funcResult.dataFrame.get.isStreaming =>
+ flow match {
+ case _ if flow.once => new AppendOnceFlow(flow, funcResult)
Review Comment:
Yep.
1. All the tests pass
2. The type of `flow` is known upon calling the method (checked statically
by Scala compiler and enforced at runtime IMHO)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
