sryza commented on code in PR #52538:
URL: https://github.com/apache/spark/pull/52538#discussion_r2467732042
##########
sql/pipelines/src/main/scala/org/apache/spark/sql/pipelines/graph/GraphRegistrationContext.scala:
##########
@@ -50,20 +50,26 @@ class GraphRegistrationContext(
sinks += sinkDef
}
- def getViews(): Seq[View] = {
- return views.toSeq
+ def getViews: Seq[View] = {
+ views.toSeq
}
- def getSinks: Seq[Sink] = sinks.toSeq
+ def getSinks: Seq[Sink] = {
+ sinks.toSeq
+ }
def registerFlow(flowDef: UnresolvedFlow): Unit = {
flows += flowDef.copy(sqlConf = defaultSqlConf ++ flowDef.sqlConf)
}
+ private def isPipelineEmpty: Boolean = {
Review Comment:
Nitpick: `isEmpty` would be clearer. `isPipelineEmpty` makes it seem like
there's some sort of other pipeline object in play.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
