gengliangwang commented on code in PR #52655:
URL: https://github.com/apache/spark/pull/52655#discussion_r2445942409
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxTopKAggregates.scala:
##########
@@ -137,25 +137,30 @@ case class ApproxTopK(
override def dataType: DataType = ApproxTopK.getResultDataType(itemDataType)
- override def createAggregationBuffer(): ItemsSketch[Any] = {
+ override def createAggregationBuffer(): ApproxTopKAggregateBuffer[Any] = {
val maxMapSize = ApproxTopK.calMaxMapSize(maxItemsTrackedVal)
- ApproxTopK.createAggregationBuffer(expr, maxMapSize)
+ val sketch = ApproxTopK.createItemsSketch(expr, maxMapSize)
+ new ApproxTopKAggregateBuffer[Any](sketch, 0L)
}
- override def update(buffer: ItemsSketch[Any], input: InternalRow):
ItemsSketch[Any] =
- ApproxTopK.updateSketchBuffer(expr, buffer, input)
+ override def update(buffer: ApproxTopKAggregateBuffer[Any], input:
InternalRow):
+ ApproxTopKAggregateBuffer[Any] =
+ buffer.update(expr, input)
- override def merge(buffer: ItemsSketch[Any], input: ItemsSketch[Any]):
ItemsSketch[Any] =
+ override def merge(
+ buffer: ApproxTopKAggregateBuffer[Any],
+ input: ApproxTopKAggregateBuffer[Any]):
+ ApproxTopKAggregateBuffer[Any] =
Review Comment:
nit: indent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
