gengliangwang commented on code in PR #52655:
URL: https://github.com/apache/spark/pull/52655#discussion_r2446082960
##########
sql/core/src/test/scala/org/apache/spark/sql/ApproxTopKSuite.scala:
##########
@@ -196,13 +196,62 @@ class ApproxTopKSuite extends QueryTest with
SharedSparkSession {
)
}
- test("SPARK-52515: does not count NULL values") {
+ test("SPARK-52515: count NULL values") {
val res = sql(
"SELECT approx_top_k(expr, 2)" +
- "FROM VALUES 'a', 'a', 'b', 'b', 'b', NULL, NULL, NULL AS tab(expr);")
+ "FROM VALUES 'a', 'a', 'b', 'b', 'b', NULL, NULL, NULL, NULL AS
tab(expr);")
+ checkAnswer(res, Row(Seq(Row(null, 4), Row("b", 3))))
+ }
+
+ test("SPARK-52515: null is not in top k") {
+ val res = sql(
+ "SELECT approx_top_k(expr, 2) FROM VALUES 'a', 'a', 'b', 'b', 'b', NULL
AS tab(expr)"
+ )
checkAnswer(res, Row(Seq(Row("b", 3), Row("a", 2))))
}
+ test("SPARK-52515: null is the last in top k") {
Review Comment:
SPARK-53947?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
