HeartSaVioR commented on code in PR #52428:
URL: https://github.com/apache/spark/pull/52428#discussion_r2448278192
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala:
##########
@@ -2017,4 +2017,167 @@ class PlanParserSuite extends AnalysisTest {
assert(unresolvedRelation2.options == CaseInsensitiveStringMap.empty)
assert(unresolvedRelation2.isStreaming)
}
+
+ test("watermark clause - table & attribute reference") {
+ assertEqual(
+ """
+ |SELECT *
+ |FROM testData
+ |WATERMARK ts DELAY OF INTERVAL 10 seconds AS tbl
+ |WHERE a > 1
+ |""".stripMargin,
+ table("testData")
+ .as("tbl")
+ .watermarkUnresolved(
+ UnresolvedAttribute("ts"),
+ IntervalUtils.fromIntervalString("INTERVAL 10 seconds"))
+ .where($"a" > 1)
+ .select(UnresolvedStar(None))
+ )
+ }
+
+ test("watermark clause - table & expression with alias") {
+ assertEqual(
+ """
+ |SELECT *
+ |FROM testData
+ |WATERMARK timestamp_seconds(value) AS eventTime DELAY OF INTERVAL 10
seconds AS tbl
+ |WHERE a > 1
+ |""".stripMargin,
+ table("testData")
+ .as("tbl")
+ .watermarkUnresolved(
+ Alias(
+ UnresolvedFunction(
+ Seq("timestamp_seconds"), Seq(UnresolvedAttribute("value")),
isDistinct = false),
+ "eventTime")(),
+ IntervalUtils.fromIntervalString("INTERVAL 10 seconds"))
+ .where($"a" > 1)
+ .select(UnresolvedStar(None))
+ )
+ }
+
+ test("watermark clause - table & expression without alias") {
+ val sql =
+ """
+ |SELECT *
+ |FROM testData
+ |WATERMARK timestamp_seconds(value) DELAY OF INTERVAL 10 seconds AS tbl
+ |WHERE a > 1
+ |""".stripMargin
+ checkError(
+ parseException(sql),
+ condition = "REQUIRES_EXPLICIT_NAME_IN_WATERMARK_CLAUSE",
+ sqlState = "42000",
+ parameters = Map("sqlExpr" -> "timestamp_seconds(value)")
+ )
+ }
+
+ test("watermark clause - aliased query") {
+ assertEqual(
+ """
+ |SELECT *
+ |FROM
+ |(
+ | SELECT *
+ | FROM testData
+ |)
+ |WATERMARK ts DELAY OF INTERVAL 10 seconds AS tbl
+ |WHERE a > 1
+ |""".stripMargin,
+ table("testData")
+ .select(UnresolvedStar(None))
+ .as("tbl")
+ .watermarkUnresolved(
+ UnresolvedAttribute("ts"),
+ IntervalUtils.fromIntervalString("INTERVAL 10 seconds"))
+ .where($"a" > 1)
+ .select(UnresolvedStar(None))
+ )
+ }
+
+ test("watermark clause - subquery") {
+ assertEqual(
+ """
+ |SELECT key, time
+ |FROM
+ |(
+ | SELECT key, time
+ | FROM
+ | testData
+ | WATERMARK timestamp_seconds(ts) AS time DELAY OF INTERVAL 10
seconds
+ |)
+ |AS tbl
+ |WHERE key = 'a'
+ |""".stripMargin,
+ table("testData")
+ .watermarkUnresolved(
+ Alias(
+ UnresolvedFunction(
+ Seq("timestamp_seconds"), Seq(UnresolvedAttribute("ts")),
isDistinct = false),
+ "time")(),
+ IntervalUtils.fromIntervalString("INTERVAL 10 seconds"))
+ .select($"key", $"time")
+ .as("tbl")
+ .where($"key" === "a")
+ .select($"key", $"time")
+ )
+ }
+
+ test("watermark clause - aliasedRelation") {
+ val src1 = UnresolvedRelation(TableIdentifier("src1")).as("s1")
+ val src2 = UnresolvedRelation(TableIdentifier("src2")).as("s2")
+ assertEqual(
+ """
+ |SELECT *
+ |FROM
+ |(src1 s1 INNER JOIN src2 s2 ON s1.id = s2.id)
Review Comment:
It's just to cover the case in the parser rule one by one - I can remove
this if you think this is redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
