HeartSaVioR commented on code in PR #52428:
URL: https://github.com/apache/spark/pull/52428#discussion_r2448145209
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -2076,6 +2077,32 @@ class AstBuilder extends DataTypeAstBuilder
query)
}
+ /**
+ * Add an [[EventTimeWatermark]] to a logical plan.
+ */
+ private def withWatermark(
+ ctx: WatermarkClauseContext,
+ query: LogicalPlan): LogicalPlan = withOrigin(ctx) {
+ val expression = visitNamedExpression(ctx.namedExpression())
+
+ val namedExpression = expression match {
+ case e: NamedExpression => e
Review Comment:
I haven't checked, but we need to make sure the column we are marking as
event time to be a top level column. For that, should we still force users to
alias it explicitly if they refer to nested column?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
