Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31963587
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -79,11 +78,11 @@ final class ShuffleBlockFetcherIterator(
private[this] val localBlocks = new ArrayBuffer[BlockId]()
/** Remote blocks to fetch, excluding zero-sized blocks. */
- private[this] val remoteBlocks = new HashSet[BlockId]()
+ private[this] val remoteBlocks = new mutable.HashSet[BlockId]()
--- End diff --
nit: I know this is normal in other scala codebases (and I somewhat prefer
it myself because of the easy immutable / mutable confusion), but I think the
spark style is actually to just import the fully qualified classes, so i think
it should stay as it was before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
