aokolnychyi commented on code in PR #52599:
URL: https://github.com/apache/spark/pull/52599#discussion_r2453508755
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala:
##########
@@ -214,23 +221,31 @@ class CacheManager extends Logging with
AdaptiveSparkPlanHelper {
uncacheByCondition(spark, _.sameResult(plan), cascade, blocking)
}
- def uncacheTableOrView(spark: SparkSession, name: Seq[String], cascade:
Boolean): Unit = {
+ def uncacheTableOrView(
+ spark: SparkSession,
+ name: Seq[String],
+ cascade: Boolean,
+ blocking: Boolean = false): Unit = {
uncacheByCondition(
- spark, isMatchedTableOrView(_, name, spark.sessionState.conf), cascade,
blocking = false)
+ spark, isMatchedTableOrView(_, name, spark.sessionState.conf), cascade,
blocking)
}
- private def isMatchedTableOrView(plan: LogicalPlan, name: Seq[String], conf:
SQLConf): Boolean = {
+ private def isMatchedTableOrView(
+ plan: LogicalPlan,
+ name: Seq[String],
+ conf: SQLConf,
+ includeTimeTravel: Boolean = true): Boolean = {
def isSameName(nameInCache: Seq[String]): Boolean = {
nameInCache.length == name.length &&
nameInCache.zip(name).forall(conf.resolver.tupled)
}
- plan match {
+ EliminateSubqueryAliases(plan) match {
Review Comment:
This change is needed as our invalidation by name without cascading is not
working.
```
cacheManager.uncacheTableOrView(spark, Seq("testcat", "tbl"), cascade =
false)
```
Would not find the table in `CacheManager` as it is wrapped into a subquery
alias.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
