aokolnychyi commented on code in PR #52599:
URL: https://github.com/apache/spark/pull/52599#discussion_r2453511470
##########
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala:
##########
@@ -1853,4 +1865,486 @@ class CachedTableSuite extends QueryTest with
SQLTestUtils
assert(!spark.catalog.tableExists("SPARK_52684"))
}
}
+
+ test("cache DSv2 table with time travel") {
+ val t = "testcat.tbl"
+ val version = "v1"
+ withTable(t, "cached_tt") {
+ sql(s"CREATE TABLE $t (id int, data string) USING foo")
+ sql(s"INSERT INTO $t VALUES (1, 'a'), (2, 'b')")
+
+ // pin current version
+ pinTable("testcat", Identifier.of(Array(), "tbl"), version)
+
+ // cache pinned version
+ sql(s"CACHE TABLE cached_tt AS SELECT * FROM $t VERSION AS OF
'$version'")
+ assertCached(sql("SELECT * FROM cached_tt"))
+ assertCached(sql(s"SELECT * FROM $t VERSION AS OF '$version'"))
+ checkAnswer(sql("SELECT * FROM cached_tt"), Seq(Row(1, "a"), Row(2,
"b")))
+
+ // verify lookupCachedData finds time travel cache
+ val timeTravelDF = sql(s"SELECT * FROM $t VERSION AS OF '$version'")
+ assert(cacheManager.lookupCachedData(timeTravelDF).isDefined)
+
+ // verify base table is not cached
+ assertNotCached(sql(s"SELECT * FROM $t"))
Review Comment:
Correct. I modified the test to make sure the data is different so it is
more obvious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
