ForVic commented on PR #52068: URL: https://github.com/apache/spark/pull/52068#issuecomment-3440151781
> In short, I'd like to recommend to revise like the following, @ForVic . > > * `spark.kubernetes.driver.annotateExitException` config name might be more accurate and proper for what this PR proposes. > * `spark.exception` or `spark.exit-exception` annotation name does in the same way. Sure, my intention with the name `diagnostics` was to match the spark-on-yarn behavior, which we refer to as `diagnostics` in spark, but I have no problem changing the name. On other point, I agree, that makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
