dongjoon-hyun commented on code in PR #52068:
URL: https://github.com/apache/spark/pull/52068#discussion_r2449721518
##########
core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:
##########
@@ -1035,6 +1035,8 @@ private[spark] class SparkSubmit extends Logging {
exitCode = e.exitCode
case _ =>
}
+ // Store the diagnostics externally if enabled, but still throw to
complete the application.
+ storeDiagnostics(args, sparkConf, cause)
Review Comment:
To @ForVic , I'm not sure why you ask this question. As you see, we use
`spark.kubernetes` already in this file.
https://github.com/apache/spark/blob/e58a3db23eb54bfcd4692a4606a0fe8f4f4a902b/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala#L175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
