cloud-fan commented on code in PR #52638:
URL: https://github.com/apache/spark/pull/52638#discussion_r2464251176
##########
sql/core/src/test/scala/org/apache/spark/sql/StringLiteralCoalescingSuite.scala:
##########
@@ -214,13 +214,13 @@ class StringLiteralCoalescingSuite extends QueryTest with
SharedSparkSession {
test("R-string coalescing with regular strings") {
val testCases = Seq(
// R-string followed by regular string
- ("""SELECT R'\n' ' tab'""", """\n tab"""),
+ ("""SELECT R'\n' ' tab'""", raw"\n tab"),
// Regular string followed by R-string
- ("""SELECT 'newline ' R'\n'""", """newline \n"""),
+ ("""SELECT 'newline ' R'\n'""", raw"newline \n"),
Review Comment:
what's the coalesced token for `SELECT 'newline ' R'\n'`? it becomes
`R'newline \n'`? then what if the normal string literal has escaping inside it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
