srielau commented on PR #52638: URL: https://github.com/apache/spark/pull/52638#issuecomment-3449226824
Yeah, I need to investigate and match the existing code in master. Coalescing is not new we’re merely expanding h its use. Sent from my iPhone On Oct 26, 2025, at 6:54 PM, Wenchen Fan ***@***.***> wrote: @cloud-fan commented on this pull request. ________________________________ In sql/core/src/test/scala/org/apache/spark/sql/StringLiteralCoalescingSuite.scala<https://github.com/apache/spark/pull/52638#discussion_r2464251176>: > // Regular string followed by R-string - ("""SELECT 'newline ' R'\n'""", """newline \n"""), + ("""SELECT 'newline ' R'\n'""", raw"newline \n"), what's the coalesced token for SELECT 'newline ' R'\n'? it becomes R'newline \n'? then what if the normal string literal has escaping inside it? — Reply to this email directly, view it on GitHub<https://github.com/apache/spark/pull/52638#pullrequestreview-3381590457>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA22CFD6C6I6KCDYYP2PP7T3ZV3LPAVCNFSM6AAAAACJMY35CSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGOBRGU4TANBVG4>. You are receiving this because you authored the thread.Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
