vrozov commented on code in PR #52728:
URL: https://github.com/apache/spark/pull/52728#discussion_r2466855701
##########
pom.xml:
##########
@@ -1189,6 +1189,13 @@
<artifactId>jline</artifactId>
<version>2.14.6</version>
</dependency>
+ <dependency>
+ <groupId>software.amazon.awssdk</groupId>
+ <artifactId>bom</artifactId>
+ <version>${aws.java.sdk.v2.version}</version>
Review Comment:
@pan3793 Both `hadoop-cloud/pom.xml` and
`resource-managers/kubernetes/integration-tests/pom.xml` use `bundle` instead
of individual jar dependencies while `kinesis-asl` relies on transitive
dependencies of the producer library that use `sts`, `auth` and etc. `BOM` only
defines individual dependencies and `bundle` still requires `version` to be
specified in the dependency. Otherwise maven build fails:
```
./build/mvn -Pkubernetes-integration-tests -pl
resource-managers/kubernetes/integration-tests
Using `mvn` from path:
/local/home/vrozov/ws/spark-sbt/build/apache-maven-3.9.11/bin/mvn
[INFO] Maveniverse Nisse 0.4.6 loaded
[INFO] Nisse injecting 39 properties into User Properties
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for
software.amazon.awssdk:bundle:jar is missing. @ line 82, column 17
@
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR] The project
org.apache.spark:spark-kubernetes-integration-tests_2.13:4.1.0-SNAPSHOT
(/local/home/vrozov/ws/spark-sbt/resource-managers/kubernetes/integration-tests/pom.xml)
has 1 error
[ERROR] 'dependencies.dependency.version' for
software.amazon.awssdk:bundle:jar is missing. @ line 82, column 17
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
```
It may be necessary to see why both explicitly define dependency on `bundle`
instead of relying on transitive dependencies. Though, I think, it is outside
of the scope for this PR, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
