vrozov commented on code in PR #52728:
URL: https://github.com/apache/spark/pull/52728#discussion_r2466862084
##########
project/SparkBuild.scala:
##########
@@ -1189,12 +1189,16 @@ object DependencyOverrides {
lazy val guavaVersion =
sys.props.get("guava.version").getOrElse("33.4.0-jre")
lazy val jacksonVersion =
sys.props.get("fasterxml.jackson.version").getOrElse("2.20.0")
lazy val jacksonDeps = Bom.dependencies("com.fasterxml.jackson" %
"jackson-bom" % jacksonVersion)
- lazy val settings = jacksonDeps ++ Seq(
+ lazy val awsJavaSdkV2Version =
sys.props.get("aws.java.sdk.v2.version").getOrElse("2.29.52")
Review Comment:
Yes, I agree, it would be better to see if the property can be read from the
`pom.xml`. As it needs to be done not only for AWS Java SDK v2, I'd suggest to
do this on a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
