cloud-fan commented on code in PR #52747:
URL: https://github.com/apache/spark/pull/52747#discussion_r2476439503
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala:
##########
@@ -110,6 +110,8 @@ private[sql] object ArrowConverters extends Logging {
val writeChannel = new WriteChannel(Channels.newChannel(out))
Utils.tryWithSafeFinally {
+ arrowWriter = ArrowWriter.create(root)
Review Comment:
is there any arrow doc mentioning this "non-reusable" thing? This is a bit
supring to be, as it provides a `reset` method.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala:
##########
@@ -110,6 +110,8 @@ private[sql] object ArrowConverters extends Logging {
val writeChannel = new WriteChannel(Channels.newChannel(out))
Utils.tryWithSafeFinally {
+ arrowWriter = ArrowWriter.create(root)
Review Comment:
is there any arrow doc mentioning this "non-reusable" thing? This is a bit
supring to me, as it provides a `reset` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
