cloud-fan commented on code in PR #52747:
URL: https://github.com/apache/spark/pull/52747#discussion_r2480723224


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala:
##########
@@ -110,6 +110,8 @@ private[sql] object ArrowConverters extends Logging {
       val writeChannel = new WriteChannel(Channels.newChannel(out))
 
       Utils.tryWithSafeFinally {
+        arrowWriter = ArrowWriter.create(root)

Review Comment:
   then why do we need to create new writers if buffers are already released by 
`root.clear()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to