cloud-fan commented on code in PR #52606:
URL: https://github.com/apache/spark/pull/52606#discussion_r2487740891
##########
core/src/main/scala/org/apache/spark/MapOutputTracker.scala:
##########
@@ -942,8 +950,13 @@ private[spark] class MapOutputTrackerMaster(
}
}
- /** Unregister shuffle data */
- def unregisterShuffle(shuffleId: Int): Unit = {
+ /**
+ * Deletes the single-source-of-truth map output status information for
+ * the specified shuffle stage. This currently should only be called
+ * through [[ContextCleaner]] when the shuffle is considered no longer
+ * referenced anywhere.
+ */
Review Comment:
we usually don't repeat the doc in method override.
##########
core/src/main/scala/org/apache/spark/MapOutputTracker.scala:
##########
@@ -1522,8 +1535,8 @@ private[spark] class MapOutputTrackerWorker(conf:
SparkConf) extends MapOutputTr
}
}
- /** Unregister shuffle data. */
- def unregisterShuffle(shuffleId: Int): Unit = {
+ /** Clears the cached shuffle status for the specified shuffle stage. */
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
