cloud-fan commented on code in PR #52606:
URL: https://github.com/apache/spark/pull/52606#discussion_r2487744514
##########
core/src/main/scala/org/apache/spark/storage/BlockManagerStorageEndpoint.scala:
##########
@@ -58,7 +58,9 @@ class BlockManagerStorageEndpoint(
case RemoveShuffle(shuffleId) =>
doAsync[Boolean](log"removing shuffle ${MDC(SHUFFLE_ID, shuffleId)}",
context) {
if (mapOutputTracker != null) {
- mapOutputTracker.unregisterShuffle(shuffleId)
+ // SPARK-53898: call `clearShuffleStatusCache()` explicitly to avoid
mistakenly
+ // clearing the single-source-of-truth shuffle status via
`unregisterShuffle()`.
Review Comment:
let's also explain the reason: who sends the `RemoveShuffle` request and for
what reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
