zifeif2 commented on code in PR #52773:
URL: https://github.com/apache/spark/pull/52773#discussion_r2491588365
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala:
##########
@@ -869,7 +880,7 @@ private[sql] class RocksDBStateStoreProvider
endVersion,
snapshotVersionStateStoreCkptId,
endVersionStateStoreCkptId)
- new RocksDBStateStore(endVersion, stamp, readOnly)
+ new RocksDBStateStore(endVersion, stamp, readOnly,
forceSnapshotOnCommit = false)
Review Comment:
Assuming this is false because there shouldn't be new changelog file
generated in a read store, so we won't have the issue of not generating
snapshot fast enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
