zifeif2 commented on code in PR #52773:
URL: https://github.com/apache/spark/pull/52773#discussion_r2520298788


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStoreCoordinator.scala:
##########
@@ -317,6 +357,10 @@ private class StateStoreCoordinator(
       stateStoreLatestUploadedSnapshot --= storeIdsToRemove
       // Remove the corresponding run id entries for report time and starting 
time
       lastFullSnapshotLagReportTimeMs -= runId
+      // Remove the corresponding run id entries for snapshot upload lagging 
stores
+      if (forceSnapshotUploadOnLag) {

Review Comment:
   Yeah it's optional. Putting it here so that it's consistent with 
LogLaggingStateStores where we always check the flag before modifying 
snapshotUploadLaggingStores



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to