sunchao commented on code in PR #52867:
URL: https://github.com/apache/spark/pull/52867#discussion_r2497667235


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala:
##########
@@ -460,10 +460,19 @@ private[spark] object Config extends Logging {
       .stringConf
       .createOptional
 
+  val KUBERNETES_EXECUTOR_POD_DELETION_COST =
+    ConfigBuilder("spark.kubernetes.executor.podDeletionCost")
+      .doc("Value to set for the controller.kubernetes.io/pod-deletion-cost" +

Review Comment:
   nit: we can emphasize that this must be set when dynamic allocation is 
enabled and the deployment-based allocator is enabled. 
   
   Also, do we need this configuration at all? can we just set this to some 
large number such as 100 when deployment-based allocator and dynamic allocation 
is enabled?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to