ForVic commented on code in PR #52867:
URL: https://github.com/apache/spark/pull/52867#discussion_r2511433618
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala:
##########
@@ -460,10 +460,19 @@ private[spark] object Config extends Logging {
.stringConf
.createOptional
+ val KUBERNETES_EXECUTOR_POD_DELETION_COST =
+ ConfigBuilder("spark.kubernetes.executor.podDeletionCost")
+ .doc("Value to set for the controller.kubernetes.io/pod-deletion-cost" +
Review Comment:
I'll make the doc more explicit.
On point 2, I think we should have the value, in case other users of it have
some sort of custom pod template or PDB usage that sets pod deletion cost on
some pods already. Given that we can't assume the value that they are using for
their labels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
